Skip to content

fix: windows resource busy/locked #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2025
Merged

fix: windows resource busy/locked #203

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deeb5df
fix: windows resource busy/locked
avik-pal Mar 17, 2025
b34381b
fix: log as debug
avik-pal Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/ReTestItems.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,12 @@ function _runtests_in_current_env(
Test.TESTSET_PRINT_ENABLE[] = true
# Cleanup test setup logs
foreach(Iterators.filter(endswith(".log"), readdir(RETESTITEMS_TEMP_FOLDER[], join=true))) do logfile
rm(logfile; force=true) # `force` to ignore error if file already cleaned up
try
# See https://github.com/JuliaTesting/ReTestItems.jl/issues/124
rm(logfile; force=true) # `force` to ignore error if file already cleaned up
catch err
@warn "Error while attempting to remove $(logfile)" err
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need to log this to the user as a warning? is a @debug enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

end
end
end
return nothing
Expand Down
Loading