-
Couldn't load subscription status.
- Fork 9
[WIP] Try to filter test items without constructing the AST #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: td-include-tasks
Are you sure you want to change the base?
Conversation
eef17f7 to
456f1d1
Compare
| Random = "1" | ||
| Serialization = "1" | ||
| Sockets = "1" | ||
| StringViews = "1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can't (don't want) any non-stdlib deps... how much benefit does StringViews give us? Our options are (i think): drop it, reimplement a minimal version, vendor it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing this gives is the ability to run regexes against a view of a Vector{UInt8} (and comparing them to Strings, but that is easy to do manually)
Project.toml
Outdated
|
|
||
| [compat] | ||
| Dates = "1" | ||
| JuliaSyntax = "0.4, 1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this we'd probably have to vendor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we go from using JuliaSyntax to using Base.JuliaSyntax 😈
This also means we're not validating every test item on every run -- only those that match the name will be evaluated.