Skip to content

Rebuild TZData before benchmarks #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamed2 merged 1 commit into from
Oct 7, 2021
Merged

Rebuild TZData before benchmarks #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ jobs:
git fetch origin +:refs/remotes/origin/HEAD
julia --project=benchmark/ -e 'using Pkg; Pkg.instantiate(); Pkg.develop(PackageSpec(path=pwd()))'
julia --project=benchmark/ -e 'using PkgBenchmark, TimeZones; export_markdown(stdout, judge(TimeZones, "origin/HEAD", verbose=false))'
env:
TZDATA_VERSION: 2016j # Matches tzdata version used in tests

doctest:
name: Documentation - Julia ${{ matrix.version }}
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "TimeZones"
uuid = "f269a46b-ccf7-5d73-abea-4c690281aa53"
authors = ["Curtis Vogt <curtis.vogt@gmail.com>"]
version = "1.5.7"
version = "1.5.8"

[deps]
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
Expand Down
6 changes: 5 additions & 1 deletion benchmark/benchmarks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using BenchmarkTools
using Dates: Period, Day, Hour, DateFormat, @dateformat_str
using TimeZones
using TimeZones.TZData: parse_components
using TimeZones.TZData: parse_components, build
using Test: GenericString

const SUITE = BenchmarkGroup()
Expand All @@ -11,6 +11,10 @@ function gen_range(num_units::Period, tz::TimeZone)
return StepRange(zdt, oneunit(num_units), zdt + num_units)
end

# Ensure that when comparing benchmarks
# That the compiled TZData is compatible with this version
build("2016j") # version consistent with tests

include("tzdata.jl")
include("interpret.jl")
include("zoneddatetime.jl")
Expand Down