Rebuild TZData before benchmarks#360
Merged
iamed2 merged 1 commit intoJuliaTime:masterfrom Oct 7, 2021
Merged
Conversation
c3f7a83 to
6a17d86
Compare
Contributor
Author
|
Here's how I tested this: My script for running the benchmarks was git clean -dfX && julia --project=@. -e 'using Pkg; Pkg.build("TimeZones")'
git fetch origin +:refs/remotes/origin/HEAD
julia --project=benchmark/ -e 'using Pkg; Pkg.instantiate(); Pkg.develop(PackageSpec(path=pwd()))'
julia --project=benchmark/ -e 'using PkgBenchmark, TimeZones; export_markdown(stdout, judge(TimeZones, "origin/HEAD", verbose=false))'And then when comparing to changes in #354 I added the same changes and ran: git clean -dfX && julia --project=@. -e 'using Pkg; Pkg.build("TimeZones")'
git fetch origin +:refs/remotes/origin/HEAD
julia --project=benchmark/ -e 'using Pkg; Pkg.instantiate(); Pkg.develop(PackageSpec(path=pwd()))'
julia --project=benchmark/ -e 'using PkgBenchmark, TimeZones; export_markdown(stdout, judge(TimeZones, "wy/clean-benchmark", verbose=false))' |
6a17d86 to
9aa7241
Compare
iamed2
approved these changes
Oct 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This recompiles TZData before running benchmarks to ensure benchmarks still run when the serialized TZdata is changed