Raise the min julia version to 1.3 #361
Conversation
|
1.3 tests are failing as in julia 1.3 |
Turns out there is no 1.3.2. |
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
==========================================
+ Coverage 93.30% 94.27% +0.97%
==========================================
Files 32 32
Lines 1613 1607 -6
==========================================
+ Hits 1505 1515 +10
+ Misses 108 92 -16
Continue to review full report at Codecov.
|
|
A couple more changes needed: TimeZones.jl/src/tzdata/download.jl Lines 4 to 9 in 0e67ab1 TimeZones.jl/src/winzone/WindowsTimeZoneIDs.jl Lines 56 to 61 in 0e67ab1 |
Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
This reverts commit 84b351b.
Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
omus
left a comment
There was a problem hiding this comment.
Overall looks good. I've identified a few more things we can clear out due to dropping Julia 1.0 (e.g. tzdata_download and friends) but I can tackle that in another PR.
Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
| else | ||
| download(WINDOWS_ZONE_URL, xml_file) | ||
| end | ||
| download(WINDOWS_ZONE_URL, xml_file) |
There was a problem hiding this comment.
I just notice this is backwards. Will address
Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
As discussed in #354 raising min version to 1.3 will let use InlineStrings.jl