Skip to content

Debugging: on Windows, try appending ssh (instead of prepending) #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DilumAluthge wants to merge 2 commits into from
Closed

Debugging: on Windows, try appending ssh (instead of prepending) #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8be29df
Debugging: on Windows, try appending `ssh` (instead of prepending)
DilumAluthge May 7, 2025
91b54ec
Update ci.yml
DilumAluthge May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ name: CI

on:
pull_request:
branches:
- master
push:
branches:
- master
Expand Down
13 changes: 9 additions & 4 deletions src/git_function.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,15 @@
path = split(get(ENV, "PATH", ""), pathsep)
libpath = split(get(ENV, LIBPATH_env, ""), pathsep)

path = vcat(dirname(OpenSSH_jll.ssh_path), path)
libpath = vcat(OpenSSH_jll.LIBPATH_list, libpath)
path = vcat(dirname(Git_jll.git_path), path)
libpath = vcat(Git_jll.LIBPATH_list, libpath)
@static if Sys.iswindows()

Check warning on line 59 in src/git_function.jl

View check run for this annotation

Codecov / codecov/patch

src/git_function.jl#L59 

Added line #L59 was not covered by tests
# Windows: we append OpenSSH_jll to the end of PATH
path = vcat(dirname(Git_jll.git_path), path, dirname(OpenSSH_jll.ssh_path))
libpath = vcat(Git_jll.LIBPATH_list, libpath, OpenSSH_jll.LIBPATH_list)
else
# All other platforms: we prepend OpenSSH_jll to the begining of PATH
path = vcat(dirname(Git_jll.git_path), dirname(OpenSSH_jll.ssh_path), path)
libpath = vcat(Git_jll.LIBPATH_list, OpenSSH_jll.LIBPATH_list, libpath)
end

unique!(filter!(!isempty, path))
unique!(filter!(!isempty, libpath))
Expand Down
Loading