Don't do the OpenSSH_jll stuff on Windows
#62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dpa/openssh_jll #62 +/- ##
================================================
Coverage 96.96% 96.96%
================================================
Files 1 1
Lines 33 33
================================================
Hits 32 32
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Alright, CI is all green here, and per #55 (comment) I don't think we need to do any |
giordano
approved these changes
May 7, 2025
giordano
added a commit
that referenced
this pull request
May 8, 2025
…SSH_jll (instead of the system `ssh`) (#55) * Use `ssh` from `OpenSSH_jll` instead of relying on system one * Add tests * Remove unnecessary `cd()` in tests * Mark a test as skipped if not CI * Apply suggestions from code review Co-authored-by: Mosè Giordano <[email protected]> * Make sure secret is available * Use `run()` so we can see stdout and stder * Add back also `Git_jll` paths * ssh -vvv * chmod 600 our private key * Linux github.com known hosts * mkdir -p ~/.ssh (linux) * Windows known hosts * Whitespace * Update runtests.jl * Don't do the `OpenSSH_jll` stuff on Windows (#62) * Don't do the `OpenSSH_jll` stuff on Windows * Run CI on all PRs (regardless of the target branch) * Test suite: turn off SSH verbosity * Apply suggestions from code review --------- Co-authored-by: Mosè Giordano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on my testing in #55 (comment)