Skip to content

Fix trailing task precompilation issue on 1.9. Run CI on 1.9 #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IanButterworth merged 2 commits into from
Nov 25, 2024
+2 −0
Merged

Fix trailing task precompilation issue on 1.9. Run CI on 1.9 #1201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5df21d4
fix and test 1.9
IanButterworth Nov 25, 2024
860b9af
Update ci.yml
IanButterworth Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
version:
- 'min'
- 'lts'
- '1.9' # test because we know there was a precompilation issue on 1.9 issues/1202
- '1' # automatically expands to the latest stable 1.x release of Julia
- 'nightly'
os:
Expand Down
1 change: 1 addition & 0 deletions src/precompile.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,6 @@ using PrecompileTools: @setup_workload, @compile_workload
end

HTTP.forceclose(server)
yield() # needed on 1.9 to avoid some issue where it seems a task doesn't stop before serialization
server = nothing
end