Fix _ossl_modules_path() returning wrong path to ossl-modules
#40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should use `libssl_path` instead of `libssl`, as in the other branch of the conditional. Note that this `ossl-modules` directory does not seem to be getting properly installed in the new OpenSSL_jll that is being shipped with Julia as a standard library.
Contributor
Author
|
Note that because JuliaLang/julia#58405 will cause precompiling this package to throw an error, after merging this we should probably mark all previous versions of OpenSSL as not compatible with Julia v1.13 (and any other version that JuliaLang/julia#58405 gets backported to). |
Letsencrypt rotates which subordinate you get [0] so we can't rely entirely on the last `CN=XX` field, let's just check the others. [0] https://letsencrypt.org/certificates/#subordinate-intermediate-cas
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should use
libssl_pathinstead oflibssl, as in the other branch of the conditional. Note that thisossl-modulesdirectory does not seem to be getting properly installed in the new OpenSSL_jll that is being shipped with Julia as a standard library.I am fixing this because after JuliaLang/julia#58405 this will error out as
dirname(::LazyLibrary)does not exist.