Skip to content

Remove use of at-async in SSLStream close #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove use of at-async in SSLStream close #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/ssl.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,16 +682,10 @@ function Base.close(ssl::SSLStream, shutdown::Bool=true)
Base.@lock ssl.lock begin
ssl.closed && return
ssl.closed = true
if shutdown
try
ssl_disconnect(ssl.ssl)
catch err
@debug "SSL disconnect failed" err
end
end
shutdown && ssl_disconnect(ssl.ssl)
free(ssl.ssl)
end
@async try
try
Base.close(ssl.io)
Copy link

@rossviljoen rossviljoen Oct 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't close acquire the iolock, and therefore is not permitted in a finalizer either?

catch e
e isa Base.IOError || rethrow()
Expand Down
Loading