fix: invalid assets path #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assets were copied into a wrong directory if TypeDoc was configured with 'outputs' option instead of 'out'. See: TypeStrong/typedoc#2996 (comment)
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where assets were being copied to an incorrect directory when TypeDoc is configured with the 'outputs' option instead of 'out'. The fix ensures assets are copied to the correct output directory by using the event's outputDirectory property instead of directly accessing the application options.
- Updated the RendererEvent.END handler to use the event parameter for accessing the output directory
- Replaced direct access to application options with the event's outputDirectory property
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Owner
|
Thank you for your cooperation on this project 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assets were copied into a wrong directory if TypeDoc was configured with 'outputs' option instead of 'out'. See: TypeStrong/typedoc#2996 (comment)