feat: consider missing import as dynamic #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As of today the
DynamicImportCheckerwill look for animportwith a specific specifier (the module specifier) meaning that imports using a dynamic value as specifier are not considered dynamic.In the following example we are dynamically importing the modules present in the
./app/controllersfolder. But they are not marked as dynamically imported by hot-hook.Solution
We should consider the dependency graph as a source of truth meaning that if we do not find any import for a given specifier in the parent we can consider that it is imported with a dynamic value.
BTW
I also fixed an issue where hot-hook would fail when deleting a file. As
realpathresolves the full canonical path by following symlinks it throws anENOENTwhen the file does no exist.