22 UI bug by Julius-Babies · Pull Request #25 · Julius-Babies/JH_DVBerry

Julius-Babies · 2025-06-10T14:40:45Z

I will review the changes now

Julius-Babies

Small changes, someone else needs to approve this since I started this pr and therefore cannot approve it.

Julius-Babies · 2025-06-10T14:43:29Z

app/src/main/java/org/jugendhackt/wegweiser/MainActivity.kt

                provider,
-                1000L,  // 1 Sekunde
-                1f,     // 1 Meter
+                1000L, 


So-called "Magic-numbers" should be defined using a constant at a somewhat top level given the importance of those. See https://en.wikipedia.org/wiki/Magic_number_(programming)?useskin=vector

Also include the unit in the constant name. I suggest using Kotlin's const-keyword (see https://kotlinlang.org/docs/properties.html#compile-time-constants)

Julius-Babies · 2025-06-10T14:44:57Z

app/src/main/java/org/jugendhackt/wegweiser/MainActivity.kt

This file seems rather large, consider refactoring some components into useful separate files enhancing reusability and testability in the future. However, this is not necessary yet so feel free to just skip this :)

…on detection radius from 200m to 250m for better user experience - Fix S-Bahn line announcements to avoid Gleis prefix - Improve platform name handling to remove redundant Gleis prefixes - Fix German text for eine Minute delay announcement - Refactor line announcement logic for different transport types: S-Bahn: S1 in Richtung X an Gleis Y, Trains: Gleis RE1 in Richtung X an Gleis Y, Bus/Tram: Linie 62 in Richtung X an Steig Y

Belgarus · 2025-06-11T19:08:29Z

Okay, I’ll keep working on this a bit more, but right now everything seems to be working fine.

…object with location-related constants - Add provider-specific time and distance thresholds - Add sensor-related constants - Improve code maintainability and readability - Make configuration values easier to modify

…ffixes to constant names (METERS, MILLIS, NANOS) - Use Kotlin const keyword for compile-time constants - Remove redundant comments as units are now in names - Update all constant references throughout the code - Improve code readability and maintainability

Refactor MainActivity to use Compose and MVVM architecture. Adjust Play/Pause button to take up 50% of screen height and optimize station departure display to show only next departure per line. Add proper delay indicators and improve loading states. Fix location permission handling and station distance calculation.

Belgarus · 2025-06-11T19:55:50Z

My main changes:


- Refactor MainActivity to use Compose and MVVM architecture
- Adjust Play/Pause button to 50% screen height
- Show only next departure per line/destination
- Add proper delay indicators (+/-) for departures
- Fix location permission handling
- Fix station distance calculation

Demo.mp4

TTS works perfectly fine, but sound doesn’t seem to work in the markup, I guess.

Belgarus · 2025-06-11T19:57:22Z

Should I simplify the files a bit more? It’s quite a lot of code.

Belgarus · 2025-06-11T19:59:44Z

Would you mind testing if the app works on your device too? I’ve only tried it on my old Android phone so far.

Julius-Babies · 2025-06-11T20:40:40Z

Should I simplify the files a bit more? It’s quite a lot of code.

Next time, split these changes into multiple tickets and pull requests (PRs). I saw something related to translations in the changes that has nothing to do with the initial issue #22. It's really hard to review these massive PRs, that's why it takes so long.

Would you mind testing if the app works on your device too? I’ve only tried it on my old Android phone so far.

If it works on your device, it should also work on newer ones. If you're able to test it on an emulator with a more recent version of Android, feel free to do so. If the app works on there too, I'll merge this and we forget that this big PR ever existed ;)

Belgarus · 2025-06-11T21:01:59Z

Okay I will test it and will look that everything works fine. :)

Belgarus · 2025-06-13T09:50:44Z

The Emulator is stuck loading. Should I open a new PR?

Belgarus · 2026-01-06T09:06:31Z

Can we merge this as an unstable version?

Julius-Babies

Since I opened this PR, I cannot approve nor request changes. If you clean up the unnecessary stuff we can merge this since we have to do some architectural planning anyways later on.

Julius-Babies · 2026-02-27T12:51:38Z

app/src/main/java/org/jugendhackt/wegweiser/dvb/DVB.kt

                        val plannedTime = extractLocalTimeFromDateString(it.scheduleTime)
                        val actualTime = extractLocalTimeFromDateString(realTime)
-                        (plannedTime.hour - actualTime.hour) * 60 + (plannedTime.minute - actualTime.minute)
+                        (actualTime.hour - plannedTime.hour) * 60 + (actualTime.minute - plannedTime.minute)


Maybe we should switch to kotlinx.datetime to get access to the Duration class which allows something like (actualTime - plannedTime).inWholeMinutes.

If you want to work on something, you should check the library out: https://github.com/Kotlin/kotlinx-datetime

This would be a required step to make the app work on iOS, since the LocalDate class we are currently using is a Java-Class which we are unable to utilize when targeting non-Android platforms. Feel free to create a master ticket for Kotlin Multiplatform for iOS (see https://kotlinlang.org/docs/multiplatform/kmp-overview.html) and a child ticket for the replacement of java DateTime API with the Kotlin alternative.

Julius-Babies · 2026-02-27T12:52:51Z

app/src/main/java/org/jugendhackt/wegweiser/dvb/DVB.kt

+                        emptyList<Station>()
+                    } else {
+                        Log.d("DVBSource", "JSON content length: ${content.length}")
+                        Log.d("DVBSource", "First 100 characters: ${content.take(100)}")


We don't need to log this

Julius-Babies · 2026-02-27T12:53:48Z

app/src/main/java/org/jugendhackt/wegweiser/dvb/DVB.kt

-                    Station(it.properties.number, it.properties.name, it.geometry.coordinates[0], it.geometry.coordinates[1], emptyList())
+        Log.d("DVBSource", "Starting to load stations from raw resource")
+        return try {
+            val inputStream = context.resources.openRawResource(R.raw.stops)


This should be deferred to the VVO-Api in the long term, so we can also get rid of the batch script which generates the json. Feel free to create a ticket.

Julius-Babies · 2026-02-27T12:58:57Z

app/src/main/java/org/jugendhackt/wegweiser/SplashActivity.kt

Do we need a dedicated activity for this? We have a loading indicator on the main activity

Julius-Babies · 2026-02-27T12:59:19Z

updateStops

Either complete or remove this file

Belgarus and others added 9 commits April 23, 2025 22:47

added logs for toubleshooting

8bdffb7

fixed first few issues

2f2b403

fixed issues but its still loading

cce1a93

replaced the threads in favor of Kotlin Coroutines

ba16d22

current status, I dont know how to fix it at the moment

1c8db40

fixed the UI-Problem

beb23a2

Create updateStops

accef4e

major changes

a833ee6

Merge remote-tracking branch 'origin/22-ui-bug' into 22-ui-bug

309a362

Julius-Babies self-assigned this Jun 10, 2025

Julius-Babies linked an issue Jun 10, 2025 that may be closed by this pull request

Heavy computations blocking UI Thread #22

Open

Julius-Babies commented Jun 10, 2025

View reviewed changes

Julius-Babies assigned Belgarus Jun 10, 2025

Julius-Babies mentioned this pull request Jun 10, 2025

Heavy computations blocking UI Thread #22

Open

Julius-Babies requested a review from Belgarus June 10, 2025 14:47

Belgarus added 4 commits June 11, 2025 21:10

the train-delay is now displayed on the UI

4231a09

fix: splash screen drawable crash

76f4349

fixed DefaultLocale warning

b225e76

Belgarus added bug Something isn't working problem state:in_progress Someone is working on this labels Feb 27, 2026

Julius-Babies commented Feb 27, 2026

View reviewed changes

Merge branch 'main' into 22-ui-bug

56df11a

Conversation

Julius-Babies commented Jun 10, 2025

Uh oh!

Julius-Babies left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Belgarus commented Jun 11, 2025

Uh oh!

Belgarus commented Jun 11, 2025

My main changes:

Uh oh!

Belgarus commented Jun 11, 2025

Uh oh!

Belgarus commented Jun 11, 2025

Uh oh!

Julius-Babies commented Jun 11, 2025

Uh oh!

Belgarus commented Jun 11, 2025

Uh oh!

Belgarus commented Jun 13, 2025

Uh oh!

Belgarus commented Jan 6, 2026

Uh oh!

Julius-Babies left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Julius-Babies left a comment •

edited

Loading