Add run_path to control execution directory independently of output#494
Open
jariji wants to merge 4 commits intoJunoLab:masterfrom
Open
Add run_path to control execution directory independently of output#494jariji wants to merge 4 commits intoJunoLab:masterfrom
jariji wants to merge 4 commits intoJunoLab:masterfrom
Conversation
Julia 1.12 added source locations to ParseError messages and module names to UndefVarError messages. These differ between the test's include_string(Main, ...) and Weave's execution context (temp files, sandbox module). Normalize these context-dependent parts before comparing error strings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Test Julia lts, 1 (stable), and pre (allow-failure) - Drop x86 and Julia 1.5 - Add julia-actions/cache@v3 - Update checkout@v6, setup-julia@v2, codecov@v5 - Add concurrency groups to cancel redundant runs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
`weave()` previously conflated the code execution directory with the output directory via the single `out_path` parameter. This made it impossible to e.g. run code from the document's directory while writing output to the current working directory. Public API: add a `run_path` keyword argument to `weave()` that independently controls where code is executed. When unset (the default), the previous behavior is preserved: code runs in the output directory. Supported values are `:doc`, `:pwd`, a path string, or `nothing`. Also supported as `run_path` in the YAML `weave_options` header. Internal: rename the `WeaveDoc.cwd` field to `out_dir` and the `get_cwd` helper to `get_out_dir` for clarity. Backward compatibility for `doc.cwd` access is preserved via getproperty/setproperty! overrides. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jariji
force-pushed
the
separate-run-and-out-dirs
branch
from
db8e1e3 to
103f1df
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #494 +/- ##
==========================================
+ Coverage 74.01% 74.51% +0.49%
==========================================
Files 26 26
Lines 1351 1448 +97
==========================================
+ Hits 1000 1079 +79
- Misses 351 369 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
weave()previously conflated the code execution directory with the output directory via the singleout_pathparameterrun_pathkeyword argument that independently controls where code is executed, e.g.weave("doc.jmd", out_path=:pwd, run_path=:doc)outputs to the cwd while running code from the document's directorynothing(default, preserves previous behavior),:doc,:pwd, or a path stringrun_pathin the YAMLweave_optionsheaderWeaveDoc.cwd→out_dirandget_cwd→get_out_dir(backward compat fordoc.cwdpreserved via property overrides)Depends on #493.
Test plan
run_path=:docwithout_path=:pwdto verify independent control🤖 Generated with Claude Code