add option to unset proxy env vars

Author: pfitzseb

lib/connection/local.coffee

@@ -6,7 +6,7 @@ junorc = client.import 'junorc', false
 
 cycler = require './process/cycler'
 ssh = require './process/remote'
-basic = require './process/basic2'
+basic = require './process/basic'
 
 module.exports =
   consumeGetServerConfig: (getconf) ->

lib/connection/process/basic.coffee

@@ -19,20 +19,32 @@ export function get (path, args) {
 }
 
 export function get_ (path, args) {
+  const env = customEnv()
+  if (process.platform == 'win32') {
+    return getWindows(path, args, env)
+  } else {
+    return getUnix(path, args, env)
+  }
+}
+
+export function customEnv (env = process.env) {
   let confnt = atom.config.get('julia-client.juliaOptions.numberOfThreads')
   let confntInt = parseInt(confnt)
 
   if (confnt == 'auto') {
-    process.env.JULIA_NUM_THREADS = require('physical-cpu-count')
+    env.JULIA_NUM_THREADS = require('physical-cpu-count')
   } else if (confntInt != 0 && isFinite(confntInt)) {
-    process.env.JULIA_NUM_THREADS = confntInt
+    env.JULIA_NUM_THREADS = confntInt
   }
 
-  if (process.platform == 'win32') {
-    return getWindows(path, args, process.env)
-  } else {
-    return getUnix(path, args, process.env)
+  if (atom.config.get('julia-client.disableProxy')) {
+    delete env.HTTP_PROXY
+    delete env.HTTPS_PROXY
+    delete env.http_proxy
+    delete env.https_proxy
   }
+
+  return env
 }
 
 // TODO: reduce code duplication in getUnix and getWindows

lib/connection/process/basic2.js renamed to lib/connection/process/basic.js

@@ -1,11 +1,11 @@
 {isEqual} = require 'underscore-plus'
-basic2 = require './basic2'
+basic = require './basic'
 
 IPC = require '../ipc'
 
 module.exports =
   provider: ->
-    basic2
+    basic
 
   cacheLength: 1
 

lib/connection/process/cycler.coffee

@@ -510,6 +510,15 @@ config =
     type: 'array'
     default: ['source.julia', 'source.weave.md', 'source.weave.latex']
     order: 6
+  disableProxy:
+    title: 'Disable System Proxy for Child Processes'
+    description:
+      'This unsets the `HTTP_PROXY` and `HTTPS_PROXY` environment variables in all integrated
+       terminals. Try this option if you\'re experiencing issues when installing Julia packages
+       in Juno.'
+    type: 'boolean'
+    default: false
+    order: 7
 
   firstBoot:
     type: 'boolean'

lib/package/config.coffee

@@ -1,6 +1,7 @@
 'use babel'
 
 import { client } from '../connection'
+import { customEnv } from '../connection/process/basic'
 import { CompositeDisposable } from 'atom'
 import { paths } from '../misc'
 import modules from './modules'
@@ -308,11 +309,13 @@ function shellPty (cwd) {
           })
           cwd = paths.home()
         }
+        env = customEnv()
         resolve({
           pty: pty.fork(atom.config.get("julia-client.consoleOptions.shell"), [], {
             cols: 100,
             rows: 30,
-            cwd: cwd
+            cwd: cwd,
+            env: env
           }),
           cwd: cwd})
       } else {