-
Notifications
You must be signed in to change notification settings - Fork 72
Type script #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type script #704
Conversation
85840aa
to
08501f8
Compare
tslint - Turn of variable-name Update tslint.json Update tslint.json
Update package.json
Powershell: decaffeinate .\lib_src --use-js-modules --loose decaffeinate .\lib_src --modernize-js cd .\lib_src Get-ChildItem *.coffee -Recurse | foreach { Remove-Item -Path $_.FullName }
js-to-ts-converter .\lib_src
04d48c7
to
a828d2f
Compare
Starting with misc/scopes.ts tsconfig Separate source-map Update tsconfig.json Update scopes.ts
misc/blocks type definitions Update blocks.ts
a44f3ce
to
065985f
Compare
d1fab47
to
04c1c23
Compare
This comment has been minimized.
This comment has been minimized.
15bb18e
to
ddc81fe
Compare
07cbac6
to
52b7237
Compare
Fix arch Install latest eslint Adding postinstall.js Add npm/apm install Add typescript to deps Using latest node + using ci only Fix space before OS Fix syntax
Add options to waitsForPromise Simplify waitsForPromise again
Add apm install ink and language-julia Simplify versions Remove apm install from Lint latest atom-setup UziTech/action-setup-atom@1 UziTech/action-setup-atom@v1 julia_version
GitHub actions
I use Github actions instead of Travis and Appveyor. For some reason you can only see the running actions here: I think you need to enable Github Actions for the master branch (or something similar). Spec doesn't run online though. Only building the package/linting is enabled in the CI. Edit: The spec fails to load ink and language-julia. So I thought maybe it is because of the old jasmine syntax. I tried to update the tests in aminya#3, but it is harder than it seems. |
- type definition - take hex function out - optimizations + other edits - add TODOs - prettier
- Add type definitions - Optimize for loop - Add sanity check for getActiveTextEditor - Prettier
This is closed in favor of #705. It distills this PR into smaller ones. |
Converting codebase to TypeScript
adding configurations
decaffeinate
js-to-ts
linting for JS, TS, Coffee
Use Github actions instead of Travis and Appveyor. See the running actions here: https://github.com/aminya/atom-julia-client/actions?query=branch%3ATypeScript
Compiling each ts file one by one to replace the corresponding
lib
file- Using import/exports instead of requiring if possible
- Adding type definitions
- other ts fixes
- tslint
- Using atom-select-list-ts instead of space-pen-views using the similar that was made for atom-indent-detective
- Using etch-ts instead of etch
- Optimizing code wherever possible
- Using TypeAssembly if worth it
Merging ink and repeating the process for the ink
Online run spec CI
How to review?
Use commits history instead of going through the files. I keep compilation separate from editing (helps in case we wanted to edit the history).
https://github.com/JunoLab/atom-julia-client/pull/704/commits
Skip reviewing map files (js.map) and declaration files (d.ts) at first. Ask me to remove them if they are distracting.
lib_src
and the compiled JS is kept inlib
I test each commit offline on my system before pushing.