SDL 3.4.0 functions, structs and defines#31
Open
Abev08 wants to merge 2 commits intoJupiterRider:commentsfrom
Open
SDL 3.4.0 functions, structs and defines#31Abev08 wants to merge 2 commits intoJupiterRider:commentsfrom
Abev08 wants to merge 2 commits intoJupiterRider:commentsfrom
Conversation
Contributor
Author
|
I wanted the 2nd commit to be separate pull request as it's not connected to this one but it didn't work out :( I would like to suggest trying to load the libraries from current working directory as a priority. Before looking for them in the OS. It could be useful when trying out different library versions or when shipping out the application without requiring the user to have the library loaded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. I have added functions, structs and defines that are new in SDL 3.4.0 release.
While doing it I noticed some missing functions and structs that were present in 3.2.0 release - also added these.
From the new functions I have tested and confirmed that they work:
I don't know how to test out two new functions, but I called them, and they returned some
SDL_Errorand didn't crash or cause the app to malfunction, so I guess they work?SDL 3.4.0 adds more functions than these mentioned above. I have created bindings for them and commented them out as they are not tested.
The test app I used to test out new functions:
Another thing that I have noticed is that when
GPUDeviceis created byCreateGPURenderer()function (viaCreateGPURenderer(nil, window)call and retrieved withGetGPURendererDevice()) it shouldn't be destroyed withDestroyGPUDevice(). Doing so causes segmentation violation error. I don't know if it's correct behavior. SDL wiki doesn't mentionDestroyGPUDevice()usage onGPUDevicecreated this way. So I guess just leaving it to the OS to cleanup after the application is closed is fine.