Skip to content

Update import for backwards compatibility #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update import for backwards compatibility #169

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
636b1fc
update import for backwards compatibility
RRosio Oct 16, 2023
1f6e77e
comment on use of Notebook < 7 handlers
RRosio Oct 16, 2023
560bea3
move print statement
RRosio Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/jupyter_nbextensions_configurator/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,17 @@
import re

import yaml
from jupyter_server.base.handlers import APIHandler, JupyterHandler
from jupyter_server.utils import url_path_join as ujoin
from jupyter_server.utils import path2url
try:
# When Notebook < 7 is available, the import the Notebook handlers
from notebook.base.handlers import APIHandler
from notebook.base.handlers import IPythonHandler as JupyterHandler
from notebook.utils import url_path_join as ujoin
from notebook.utils import path2url
except ModuleNotFoundError as e:
from jupyter_server.base.handlers import APIHandler, JupyterHandler
from jupyter_server.utils import url_path_join as ujoin
from jupyter_server.utils import path2url

from notebook._version import version_info as nb_version_info
from tornado import web

Expand Down