Skip to content

Update to Xeus 4.3.4 #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
agriyakhetarpal wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Update to Xeus 4.3.4 #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
a1c6506
Retry Xeus 4.3.4
agriyakhetarpal Dec 11, 2025
f9902e7
Try removing insert-cell-below call to address crash
agriyakhetarpal Dec 11, 2025
4dd3381
Select first cell instead of last
agriyakhetarpal Dec 11, 2025
1925387
Run code with cell button instead of command
agriyakhetarpal Dec 11, 2025
668d2f7
What if we skip the test that crashes?
agriyakhetarpal Dec 11, 2025
d547c1f
Try to run tests outside Python's `http.server`
agriyakhetarpal Dec 11, 2025
2ad6306
Revert "What if we skip the test that crashes?"
agriyakhetarpal Dec 11, 2025
7317940
Revert "Run code with cell button instead of command"
agriyakhetarpal Dec 11, 2025
eeceb95
Revert "Select first cell instead of last"
agriyakhetarpal Dec 11, 2025
f6a0b8b
Try again with new path
agriyakhetarpal Dec 11, 2025
b353ea5
Try again
agriyakhetarpal Dec 11, 2025
ca8a86c
Revert "Try again"
agriyakhetarpal Dec 11, 2025
23c49c5
Revert "Try again with new path"
agriyakhetarpal Dec 11, 2025
72da918
Revert "Try to run tests outside Python's `http.server`"
agriyakhetarpal Dec 11, 2025
c4e221f
More logging...
agriyakhetarpal Dec 11, 2025
732434d
Try one more time
agriyakhetarpal Dec 11, 2025
879e31e
Try latest
krassowski Dec 15, 2025
9bf0882
Try 4.2.2
krassowski Dec 15, 2025
708f4db
4.2.1
krassowski Dec 15, 2025
a14858e
4.2.0
krassowski Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ui-tests/playwright.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,12 @@ module.exports = {
autoGoto: false,
baseURL: 'http://localhost:3000',
trace: 'retain-on-failure',
video: 'retain-on-failure'
video: 'retain-on-failure',
screenshot: 'only-on-failure',
// Capture browser console logs
launchOptions: {
args: process.env.CI ? ['--disable-dev-shm-usage'] : []
}
},
webServer: {
command: 'jlpm start',
Expand Down
44 changes: 42 additions & 2 deletions ui-tests/tests/jupytereverywhere.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import { test, expect, Page } from '@playwright/test';
import path from 'path';
import fs from 'fs';
Expand Down Expand Up @@ -1044,12 +1044,33 @@
});

test('Should switch to R kernel and run R code', async ({ page }) => {
const consoleMessages: string[] = [];
const pageErrors: string[] = [];

page.on('console', msg => {
const text = `[${msg.type()}] ${msg.text()}`;
consoleMessages.push(text);
console.log(text);
});

page.on('pageerror', error => {
const errorText = `Page error: ${error.message}\n${error.stack}`;
pageErrors.push(errorText);
console.error(errorText);
});

page.on('crash', () => {
console.error('PAGE CRASHED!');
});

await page.goto('lab/index.html');
await page.waitForSelector('.jp-NotebookPanel');

// Wait for Python kernel to fully initialise
await page.waitForTimeout(30000);

await runCommand(page, 'jupytereverywhere:switch-kernel', { kernel: 'xr' });
await page.waitForTimeout(10000);
await runCommand(page, 'notebook:insert-cell-below');
await page.waitForTimeout(30000);

const code = 'lm(mpg ~ wt + hp + disp + cyl, data=mtcars)';
const cell = page.locator('.jp-Cell').last();
Expand All @@ -1065,7 +1086,7 @@
const text = await output.textContent();
expect(text).toContain('Call');
// Add a snapshot of the output area
expect(await output.screenshot()).toMatchSnapshot('r-output.png');

Check failure on line 1089 in ui-tests/tests/jupytereverywhere.spec.ts

View workflow job for this annotation

GitHub Actions / Integration tests

[chromium] › tests/jupytereverywhere.spec.ts:1046:5 › Should switch to R kernel and run R code 

  1) [chromium] › tests/jupytereverywhere.spec.ts:1046:5 › Should switch to R kernel and run R code 
    Error: locator.screenshot: Test timeout of 60000ms exceeded.
    Call log:
      - taking element screenshot
      - waiting for fonts to load...
      - fonts loaded
      - attempting scroll into view action
        - waiting for element to be stable


      1087 |   expect(text).toContain('Call');
      1088 |   // Add a snapshot of the output area
    > 1089 |   expect(await output.screenshot()).toMatchSnapshot('r-output.png');
           |                       ^
      1090 | });
      1091 |
      1092 | test.describe('Kernel networking', () => {
        at /home/runner/work/jupyterlite-extension/jupyterlite-extension/ui-tests/tests/jupytereverywhere.spec.ts:1089:23
});

test.describe('Kernel networking', () => {
Expand All @@ -1074,6 +1095,25 @@
const expectedContent = 'col1';

test('R kernel should be able to fetch from a remote URL', async ({ page }) => {
const consoleMessages: string[] = [];
const pageErrors: string[] = [];

page.on('console', msg => {
const text = `[${msg.type()}] ${msg.text()}`;
consoleMessages.push(text);
console.log(text);
});

page.on('pageerror', error => {
const errorText = `Page error: ${error.message}\n${error.stack}`;
pageErrors.push(errorText);
console.error(errorText);
});

page.on('crash', () => {
console.error('PAGE CRASHED!');
});

await page.goto('lab/index.html?kernel=r');
await page.waitForSelector('.jp-NotebookPanel');

Expand Down
Loading