-
Notifications
You must be signed in to change notification settings - Fork 4
Use memoryStorageDriver
#85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use memoryStorageDriver
#85
Conversation
|
On second thought: we should exercise caution before merging this, as the mere act of reloading the page will cause users to lose all their code – we want to avoid this in any scenario. One way to mitigate this issue is by resolving #104, which involves sharing the notebook and generating a shareable URL on initial load (which should be better handled after merging #192). We also need to ensure that the shareable link is always included in the URL. The shareable link is also present in view-only notebooks, so we should be checking for a token that allows editing the notebook. To achieve this, we will require #105, and we should securely store the sharing service token in the browser. Current scenario
Expected scenario
We have two options: we can either merge this PR now and I will create additional PRs for #104 and #105, or I can prepare those PRs first and then return to this one. |
krassowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try this on staging, this will help to make a decision!
|
Yes, going forward with this as discussed. Merging! |
b8a7f6d
into
JupyterEverywhere:main
This reverts commit b8a7f6d.
I think it is time now that we do this. This PR sets the storage to
memoryStorageDriver(in-memory, non-persistent). Files uploaded to the Files widget and notebooks will not retain data if saved beforehand when reloaded becauseenableMemoryStorageis alsotrue.Reference: https://jupyterlite.readthedocs.io/en/latest/howto/configure/storage.html