Skip to content

⚡ Bolt: Cache RegExp instances in NexusPHP adapters to improve parsing performance#120

Open
JustLookAtNow wants to merge 1 commit intomasterfrom
bolt/cache-regexp-nexusphp-adapters-12816164061257615172
Open

⚡ Bolt: Cache RegExp instances in NexusPHP adapters to improve parsing performance#120
JustLookAtNow wants to merge 1 commit intomasterfrom
bolt/cache-regexp-nexusphp-adapters-12816164061257615172

Conversation

@JustLookAtNow
Copy link
Copy Markdown
Owner

💡 What:
Extracted dynamically compiled RegExp objects into cached variables:

  1. NexusPHPWebAdapter: Created top-level _sizeRegExp and _relativeUrlRegExp.
  2. NexusPHPAdapter: Created static final _whitespaceRegExp.

🎯 Why:
Compiling RegExp dynamically within loops and build methods in Dart is a known performance bottleneck, particularly for isolate functions processing multiple items (like search parsing) and loops over collections.

📊 Impact:
Prevents repeated regex compilations during HTML/API parsing and mapping processes. This provides a minor but measurable CPU improvement when evaluating hundreds of torrent items or mapping extensive tracker categories.

🔬 Measurement:
Run flutter test specifically for adapter parsing logic (flutter test test/nexusphp_adapter_test.dart test/nexusphp_web_adapter_test.dart) to ensure the correct behavior is maintained post-optimization. No visual changes; entirely CPU optimization on parsing logic.


PR created automatically by Jules for task 12816164061257615172 started by @JustLookAtNow

Extracted inline, dynamically compiled `RegExp` objects from methods and loops in `NexusPHPWebAdapter` and `NexusPHPAdapter` into cached top-level or static variables to avoid repeated compilation on hot paths.

Co-authored-by: JustLookAtNow <12379683+JustLookAtNow@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant