Skip to content

🎨 Palette: Add tooltips to icon-only PopupMenuButtons#122

Open
JustLookAtNow wants to merge 1 commit intomasterfrom
palette/popup-menu-tooltips-1205530211742918021
Open

🎨 Palette: Add tooltips to icon-only PopupMenuButtons#122
JustLookAtNow wants to merge 1 commit intomasterfrom
palette/popup-menu-tooltips-1205530211742918021

Conversation

@JustLookAtNow
Copy link
Copy Markdown
Owner

💡 What: Added tooltip: '选项' to PopupMenuButton widgets in the server settings page and aggregate search settings page. Cleaned up duplicate tooltip attributes in download tasks page.
🎯 Why: Icon-only menus (like PopupMenuButton) lack semantic meaning for screen readers and don't show hover feedback on desktop platforms unless a tooltip string is explicitly provided. This improves overall keyboard accessibility and UI discoverability.
📸 Before/After: Visually unchanged on mobile unless long-pressed; on desktop/web, hovering over the context menu icons now displays "选项" (Options) instead of nothing.
Accessibility: Provides necessary ARIA-equivalent labels to screen readers for critical settings actions.


PR created automatically by Jules for task 1205530211742918021 started by @JustLookAtNow

Added `tooltip: '选项'` (Options) to `PopupMenuButton` widgets in `server_settings_page.dart` and `aggregate_search_settings_page.dart`. This ensures screen readers provide context for these icon-only buttons and hover text appears on desktop. Also removed duplicate tooltip declarations on IconButton widgets in download_tasks_page.dart for cleaner code.

Co-authored-by: JustLookAtNow <12379683+JustLookAtNow@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant