Skip to content

⚡ Bolt: Cache RegExp in parsing adapters#123

Open
JustLookAtNow wants to merge 1 commit intomasterfrom
bolt-cache-regexp-optimization-14770700081820352521
Open

⚡ Bolt: Cache RegExp in parsing adapters#123
JustLookAtNow wants to merge 1 commit intomasterfrom
bolt-cache-regexp-optimization-14770700081820352521

Conversation

@JustLookAtNow
Copy link
Copy Markdown
Owner

💡 What:
Extracted RegExp object instantiations from inline usage inside NexusPHPWebAdapter and NexusPHPAdapter into top-level final variables.

🎯 Why:
In Dart, compiling regular expressions carries a performance cost. The NexusPHPWebAdapter compiles these inside a background isolate (during HTML parsing for torrent lists), and NexusPHPAdapter compiles a whitespace RegExp repeatedly inside nested loops traversing API data. Re-instantiating identical regular expressions on these hot paths results in unnecessary object allocations and CPU overhead, especially given that Dart isolate memory is discrete and requires local compilation.

📊 Impact:
Eliminates redundant RegExp compilation during list parsing and category iteration, reducing execution time and object churn.

🔬 Measurement:
Verification includes running standard Dart format, linter, and flutter test to ensure functional parity. Performance improvement can be observed in reduced parse times during operations like parseSearchResults in test/benchmark_parsing.dart.


PR created automatically by Jules for task 14770700081820352521 started by @JustLookAtNow

Extract inline RegExp instantiations from hot-path parsing loops and methods in NexusPHP adapters into lazily evaluated top-level final variables. This prevents repeated compilation during isolate execution and large list iterations.

Co-authored-by: JustLookAtNow <12379683+JustLookAtNow@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant