Skip to content

Allow for symfony/http-client ^6.0#15

Open
AJenbo wants to merge 1 commit intoJustSteveKing:mainfrom
AJenbo:patch-1
Open

Allow for symfony/http-client ^6.0#15
AJenbo wants to merge 1 commit intoJustSteveKing:mainfrom
AJenbo:patch-1

Conversation

@AJenbo
Copy link

@AJenbo AJenbo commented Jan 30, 2025

This is needed for comparability with newer versions of Laravel (11.5 PHP 8.3)

Summary by CodeRabbit

  • Dependency Update
    • Expanded compatibility for Symfony HTTP client to support versions 5.1 and 6.0

@coderabbitai
Copy link

coderabbitai bot commented Jan 30, 2025

Walkthrough

The pull request modifies the composer.json file to update the version constraint for the symfony/http-client dependency. The change expands the acceptable version range to include both version 5.1 and version 6.0 of the package, providing more flexibility in dependency management for the project.

Changes

File Change Summary
composer.json Updated symfony/http-client dependency version constraint from ^5.1 to ^5.1|^6.0

Poem

🐰 A Composer's Hop of Joy

Symfony's client, now free to roam
From version five to six, a new home
Flexibility springs with each version's might
Dependencies dancing, oh what a delight!
A rabbit's update, clean and bright 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 864c10c and 7bf04da.

📒 Files selected for processing (1)
  • composer.json (1 hunks)
🔇 Additional comments (1)
composer.json (1)

28-28: LGTM! Consider updating symfony/var-dumper for consistency.

The version constraint change looks good and is compatible with the project's PHP requirements. However, consider updating symfony/var-dumper to match the same version constraint for consistency.

Apply this diff to maintain consistency across Symfony packages:

   "require-dev": {
     "php-http/mock-client": "^1.4",
     "phpunit/phpunit": "^9.4",
-    "symfony/var-dumper": "^5.1"
+    "symfony/var-dumper": "^5.1|^6.0"
   },

Let's verify if there are any breaking changes between symfony/http-client 5.1 and 6.0 that might affect the codebase:

✅ Verification successful

Version constraint change is safe to proceed ✅

The codebase only uses Symfony's Psr18Client as a PSR-18 implementation, with no direct usage of Symfony-specific features. The upgrade path from 5.1 to 6.0 is safe as PSR-18 compatibility is guaranteed.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for breaking changes in symfony/http-client

# Search for HttpClient usage patterns that might be affected by breaking changes
rg -l 'use\s+Symfony\\Component\\HttpClient' || echo "No direct usage found"

# Check the changelog for breaking changes
curl -s https://raw.githubusercontent.com/symfony/http-client/6.0/CHANGELOG.md | grep -A 10 "6.0.0"

Length of output: 186


Script:

#!/bin/bash
# Check HttpClient usage in the files
echo "=== src/Envoyer.php ==="
rg -B 2 -A 5 'use\s+Symfony\\Component\\HttpClient|HttpClient' src/Envoyer.php

echo -e "\n=== tests/ResourcesTest.php ==="
rg -B 2 -A 5 'use\s+Symfony\\Component\\HttpClient|HttpClient' tests/ResourcesTest.php

# Try alternative changelog source
echo -e "\n=== Changelog from 6.0 branch ==="
curl -s https://raw.githubusercontent.com/symfony/http-client/6.0.x/CHANGELOG.md | head -n 20

Length of output: 2085


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@AJenbo AJenbo mentioned this pull request Feb 3, 2025
@AJenbo
Copy link
Author

AJenbo commented Feb 11, 2025

Test are failing because the composer.lock file requires PHP 8.0, this isn't related to my PR. I would suggest removing the lock file since this is a library and the lock isn't inherited by applications that install it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant