Skip to content

Comments

fix venv mkdir error "if already exists"#104

Draft
HaruNashii wants to merge 1 commit intoJustTemmie:mainfrom
HaruNashii:patch-2
Draft

fix venv mkdir error "if already exists"#104
HaruNashii wants to merge 1 commit intoJustTemmie:mainfrom
HaruNashii:patch-2

Conversation

@HaruNashii
Copy link

@HaruNashii HaruNashii commented Nov 21, 2025

this fix changes the installer.sh to remove the error log that happens when the user rerun the script, that is a minor error, but for people that is not in the tech world, seeing an "error" in the terminal may be scary

this pr code will remove the "venv directory already exists" warning with the "-p" flag to mkdir:

mkdir -p venv

there is other method that can be more robust, like:
removing the venv directory if exist, and create an new one, to unsure that everything is nicely setted

if [ -d "$PWD/venv" ]; then
	rm -r venv
fi
mkdir venv

@HaruNashii HaruNashii marked this pull request as ready for review November 21, 2025 17:48
@HaruNashii HaruNashii marked this pull request as draft November 21, 2025 17:49
@HaruNashii HaruNashii changed the title remove venv directory creator error if already exists fix venv mkdir error "if already exists" Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant