fix venv mkdir error "if already exists"#104
Draft
HaruNashii wants to merge 1 commit intoJustTemmie:mainfrom
Draft
fix venv mkdir error "if already exists"#104HaruNashii wants to merge 1 commit intoJustTemmie:mainfrom
HaruNashii wants to merge 1 commit intoJustTemmie:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fix changes the installer.sh to remove the error log that happens when the user rerun the script, that is a minor error, but for people that is not in the tech world, seeing an "error" in the terminal may be scary
this pr code will remove the "venv directory already exists" warning with the "-p" flag to mkdir:
there is other method that can be more robust, like:
removing the venv directory if exist, and create an new one, to unsure that everything is nicely setted