Skip to content

feat(vc-api): external subdomainRecordsFetcher error handling#87

Merged
Ghadi8 merged 5 commits intodevelopfrom
georges/engr-729-implement-error-handling-on-records-feching-justverified
Dec 13, 2024
Merged

feat(vc-api): external subdomainRecordsFetcher error handling#87
Ghadi8 merged 5 commits intodevelopfrom
georges/engr-729-implement-error-handling-on-records-feching-justverified

Conversation

@georgesMouawad
Copy link
Contributor

Adjusts the SubnameRecordsFetcher:

  • Makes the text param in fetchRecords required.
  • Removes (if (text) else).
  • Adds a try catch block when fetching records.

@linear
Copy link

linear bot commented Dec 11, 2024

@vercel
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
telegram-static ✅ Ready (Inspect) Visit Preview Dec 13, 2024 9:17am

@Ghadi8 Ghadi8 merged commit 39128cd into develop Dec 13, 2024
2 checks passed
@georgesMouawad georgesMouawad deleted the georges/engr-729-implement-error-handling-on-records-feching-justverified branch December 13, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants