Skip to content

Normalize parent array type#15

Merged
lkdvos merged 6 commits intomainfrom
normalize_parent
Mar 20, 2025
Merged

Normalize parent array type#15
lkdvos merged 6 commits intomainfrom
normalize_parent

Conversation

@lkdvos
Copy link
Collaborator

@lkdvos lkdvos commented Feb 27, 2025

This PR brings back a change that was present in older versions of Strided.jl, by normalizing the parent type of StridedView to only include Vector.
This main reason is this TensorOperations.jl PR which introduces some precompilation efforts, reporting a rather large amount of specializations from Strided.
While there is definitely room for adding precompilation in this package as well, to further decrease the burden on TensorOperations itself, this seems like a rather simple change that has a huge impact on the precompilation times: my machine reports ~140 seconds before, but ~40 seconds after.
Alternatively, we could also consider just normalizing the types in TensorOperations itself, but this change seems reasonable to me.

I'm not sure if this constitutes a breaking change though, given that fields are typically considered private I would say it isn't?

@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.70%. Comparing base (27b1c09) to head (c509aa5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   91.54%   91.70%   +0.16%     
==========================================
  Files           4        4              
  Lines         201      205       +4     
==========================================
+ Hits          184      188       +4     
  Misses         17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos lkdvos requested a review from Jutho March 20, 2025 15:07
@Jutho
Copy link
Owner

Jutho commented Mar 20, 2025

Look's good; I think a minor version update is ok for this, which is indeed breaking because we are still at 0.x. The only annoying thing is that we will also have to update Strided.jl because of this, and only then TensorOperations.jl. Feel free to merge; without further comments I will merge in a few hours.

@lkdvos lkdvos merged commit b27f572 into main Mar 20, 2025
16 checks passed
@lkdvos lkdvos deleted the normalize_parent branch March 20, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants