Skip to content

fix: Read SpriteBone correctly #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2023
Merged

fix: Read SpriteBone correctly #213

merged 1 commit into from
Oct 15, 2023

Conversation

Nattsu39
Copy link
Contributor

@Nattsu39 Nattsu39 commented Oct 15, 2023 •
edited
Loading

The rotation value in the SpriteBone should be read via read_quaternion. (Only tested in version 2020.3.38)

Reference: Perfare/AssetStudio#918

@Nattsu39
fix: Read SpriteBone correctly
5444a8b 
Should read rotaion in SpriteBone via read_quaternion.
(Only tested in version 2020.3.38)
@K0lb3
Copy link
Owner

K0lb3 commented Oct 15, 2023

Thanks for the PR.
The rotation should indeed be a quaternion, and that is for all versions, so all good.

@K0lb3 K0lb3 merged commit b7f7a28 into K0lb3:master Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nattsu39 @K0lb3