Conversation
Added HasExistingData method to check if the database contains data, optimizing performance by caching the result. Adjusted related fields and locking mechanisms for thread safety.
Changed processors from a slice to a map for O(1) lookup efficiency and added hasExistingData field to track existing data status.
Update initial load condition to check for existing data.
Refactor to set hasExistingData during initialization instead of in Start method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After log rotation, the splash screen would incorrectly appear even though the database already contained data. This happened because:
fileSize = 0Additionally,
hasExistingDatawas only set when sources existed at startup, causing issues when sources were added later.Fix #63
Solution
stats.go: Fix percentage calculation - return 100% whenfileSize = 0butLastPosition > 0(data was processed before rotation)http_request.go: AddHasExistingData()method with cachingcoordinator.go: MovehasExistingDatacheck toNewCoordinator()so it's always initialized before any processors are createdprocessor.go: UpdateisInitialLoadlogic to considerhasExistingDataChanges
internal/database/repositories/stats.gointernal/database/repositories/http_request.goHasExistingData()with cachinginternal/ingestion/coordinator.gohasExistingDatain constructorinternal/ingestion/processor.gohasExistingDataparameterImpact