Use CMake presets to set clazy/clang-tidy#75
Merged
Conversation
dantti
force-pushed
the
dantti/ci_improve_nightly
branch
10 times, most recently
from
9caec31 to
ff57a9c
Compare
Add cppcheck target and call it on GitHub Checks are non fatal atm, this patch includes some fixes but there are too many issues to be fixed by this. Fixed some unit tests
dantti
force-pushed
the
dantti/ci_improve_nightly
branch
from
ff57a9c to
c65d27b
Compare
iamsergio
approved these changes
May 14, 2025
| max = QPointF(values.size() - 1, -1e9); | ||
| setRowCount(values.size()); | ||
| setColumnCount(1); | ||
| setRowCount(values.size()); |
Contributor
There was a problem hiding this comment.
is this cppcheck related or just cosmetic ?
I don't care much since it's in a test, but curious
Member
Author
There was a problem hiding this comment.
This is what cause the tests to crash, setColumnCount() emitted a headerChanged signal, which triggered a code to check first and last indexes but it received the lastColumn with value of 4, likely garbage or default data, but the model wasn't populated nor had those columns...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cppcheck target and call it on GitHub
Checks are non fatal atm, this patch includes
some fixes but there are too many issues to be
fixed by this.