Skip to content

Conversation

@dfaure-kdab
Copy link
Member

COMMON_HEADER already takes care of creating it, no need to do it again with configure_file

COMMON_HEADER already takes care of creating it, no need to do
it again with configure_file
@dfaure-kdab dfaure-kdab requested a review from dantti July 10, 2025 14:37
Copy link
Member

@dantti dantti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I wonder what COMMON_HEADER generates, as maybe the list(APPEND) could also be removed?

@dfaure-kdab
Copy link
Member Author

I added a message() to debug it, and ecm_generate_headers puts all the forwarding headers into kdchart_HEADERS, but nothing else. This is why the install(FILES) below has a manual list of all the real *.h headers to install, in addition to the forwarding headers.

This means we could also just add the (generated) kdgantt.h in the install(FILES command, instead of doing list(APPEND). It's basically the same though.

@dfaure-kdab dfaure-kdab merged commit 73620df into KDAB:master Jul 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants