Finally fix spurious recompilations of KDChart-based apps #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninja was seeing KDChart.tmp as a dependency of KDChart, so the timestamp modification of KDChart.tmp (on each cmake run) would still lead to a full rebuild of everything using the KDChart header. Fixed by using file(GENERATE) which is the proper CMake API for this.
dfaure-kdab
force-pushed
the
wip/dfaure/file-generate
branch
from
8a1b3bd to
4fb6b4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ninja was seeing KDChart.tmp as a dependency of KDChart, so the timestamp modification of KDChart.tmp (on each cmake run) would still lead to a full rebuild of everything using the KDChart header.
Fixed by using file(GENERATE) which is the proper CMake API for this.