destruction_helpers.h: remove using namespace KDBindings#81
Merged
Conversation
Contributor
|
was going to suggest we don't care about cppcheck for tests, but these are new errors, can you check which make sense and blacklist checks that are nonsense |
lemirep
force-pushed
the
remove_using_kdbinding
branch
2 times, most recently
from
79a3fae to
973921d
Compare
Because headers should never have a using namespace declaration. Also fix typos, add unit tests and minimal documentation. Change-Id: Ic524c53417da7273c15c1c9eaa5f8ef8758340af
lemirep
force-pushed
the
remove_using_kdbinding
branch
from
973921d to
4af113d
Compare
Contributor
Author
|
Fixed clang-tidy and cpp-check warnings |
mkrus
approved these changes
May 27, 2025
MiKom
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because headers should never have a using namespace declaration.
Also fix typos, add unit tests and minimal documentation.
Change-Id: Ic524c53417da7273c15c1c9eaa5f8ef8758340af