Use proper hInstance when registering window class#88
Merged
Conversation
MiKom
force-pushed
the
set-proper-hinstance-on-windows-eventloop-window-class
branch
from
d3e3a3a to
8cb61dc
Compare
We passed nullptr as hInstance and this could potentially be bad if two instances of KDUtils were linked to the application (e.g. plugins). Unlikely but let's do it right. Current module is obtained through a trick where a function passes itself to GetModuleHandleEx to make sure we get the module handle of the current dll. See: https://devblogs.microsoft.com/oldnewthing/20110715-00/?p=10133
MiKom
force-pushed
the
set-proper-hinstance-on-windows-eventloop-window-class
branch
from
8cb61dc to
24e7e80
Compare
mkrus
approved these changes
Oct 17, 2025
MiKom
deleted the
set-proper-hinstance-on-windows-eventloop-window-class
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We passed nullptr as hInstance and this could potentially be bad if two instances of KDUtils were linked to the application (e.g. plugins).
Unlikely but let's do it right. Current module is obtained through a trick where a function passes itself to GetModuleHandleEx to make sure we get the module handle of the current dll.
See: https://devblogs.microsoft.com/oldnewthing/20110715-00/?p=10133