Merged
Conversation
The upstream version is not compatible with Clang >=19 so it breaks macOS builds on latest agents. Added readme that describes what's the deal. fakeit.hpp has to be added to .codespellrc explicitly because codespell actually can't properly ignore folders from .codespellrc when called from pre-commit. See codespell-project/codespell#3196
MiKom
force-pushed
the
fix-macos-builds
branch
from
e5447d5 to
e7e5351
Compare
seanharmer
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With recent changes to macOS builders we didn't properly build there anymore.