Conversation
lemirep
force-pushed
the
vcpkg
branch
3 times, most recently
from
989060f to
a145853
Compare
Member
|
Hey. I think that CI jobs fail because by default, GitHub doesn't check out submodules. We'd need |
MiKom
force-pushed
the
vcpkg
branch
12 times, most recently
from
6c0c19b to
dd851d6
Compare
Change-Id: Ic1a6ef5cf5af5b0567817392ce5fc61358b690ca
We declare the default repository with appropriate sha separately in vcpkg-configuration.json. Having "builtin-baseline" in such case generates vcpkg warning.
We don't want to check the code there, that's not our code.
Was vcpkg/vcpkg due to omission. Also, it was made shallow by default. Normally people will just want to build so there's no need to fetch it with the whole history. If someone wants to work with the submodule, it can always be unshallowed.
Otherwise, we won't get vcpkg.
Like we do in one of our internal projects. This way it will be less confusing for the user and they'll get instant feedback on what to do if they checked out without submodules.
Now vcpkg does this.
For now we only test with external dependencies on macOS. mio and whereami are not available in brew so we'll still fetch them with CMake. Doctest needed to be added to brew deps.
It didn't use the FindWhereami.cmake file because the capitalization was wrong. In find_package() we used "whereami", starting with lowercase letter.
I cannot figure out why they started popping up after switching to vcpkg. Seems that without vcpkg tests were not actually going through clang-tidy for some reason. Let's fix those then.
MiKom
approved these changes
Oct 17, 2025
iamsergio
reviewed
Oct 17, 2025
vcpkg.json
Outdated
| "description": "KD Utilities Library - Core utilities and helper functions", | ||
| "homepage": "https://github.com/KDAB/kdutils", | ||
| "license": "MIT", | ||
| "supports": "!(uwp | arm)", |
Member
There was a problem hiding this comment.
Yup, overlooked it. Now I made it more truthful.
It's just informative but let's at leas be truthful here. It doesn't mean it won't work elsewhere. Just that these are the platforms we currently test for and care about. May change in the future.
iamsergio
approved these changes
Oct 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vcpkg should hopefully be more convenient than FetchContent.
In turn KDGpu and other internal projects will be able to build KDUtils with vcpkg