Implement automatic implementations of up and downcasting by BenFordTytherington · Pull Request #1159 · KDAB/cxx-qt

BenFordTytherington · 2025-01-16T17:31:25Z

No description provided.

codecov · 2025-01-16T19:06:43Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bd0fbc7) to head (db8d215).
Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #1159   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           73        73           
  Lines        12458     12527   +69     
=========================================
+ Hits         12458     12527   +69

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/cxx-qt-gen/src/generator/rust/mod.rs

crates/cxx-qt-gen/src/generator/rust/qobject.rs

crates/cxx-qt/src/lib.rs

crates/cxx-qt/src/qobject.rs

crates/cxx-qt/src/lib.rs

crates/cxx-qt-lib/src/core/qstringlist.cpp

crates/cxx-qt-lib/src/core/qstringlist.rs

crates/cxx-qt-lib/src/gui/qguiapplication.rs

ahayzen-kdab

Overall looks good, would be nice in a future PR to add support for #[base = T] to extern "C++Qt" types too so we can do the same tricks of up/down casting there

crates/cxx-qt/src/lib.rs

ahayzen-kdab

Looks good :-) @LeonMatthesKDAB any comments ? Ben is going to look at further changes like adding more docs to the book / adding support for base to extern C++Qt so that casing can be done on those types.

But i think this is probably far enough to land this part already?

book/src/bridge/traits.md

book/src/concepts/casting.md

LeonMatthesKDAB

Only some nitpicks left from my side.

Feel free to merge after these and the comments from @ahayzen-kdab are fixed.
Another really good step forward! 🥳

book/src/concepts/casting.md

- Any bridges with qobjects that have no custom base class will get an upcasting implemention - Adds a new include with the necessary template function for calling static_cast

ahayzen-kdab

LGTM, support for C++Qt will be in another change and extending the QObject type etc. @LeonMatthesKDAB any objections ?

ahayzen-kdab · 2025-02-28T11:35:26Z

(Leon says it's good too)

BenFordTytherington force-pushed the add-up-down-casting branch 4 times, most recently from fb6ec2a to afe4181 Compare January 16, 2025 17:51

LeonMatthesKDAB mentioned this pull request Jan 20, 2025

Implement Debug for all types that work with QDebug #1162

Merged

BenFordTytherington force-pushed the add-up-down-casting branch 2 times, most recently from f3b9070 to 87b9d5a Compare February 3, 2025 13:54

BenFordTytherington marked this pull request as ready for review February 3, 2025 14:08

ahayzen-kdab reviewed Feb 3, 2025

View reviewed changes

crates/cxx-qt-gen/src/generator/rust/mod.rs Outdated Show resolved Hide resolved

ahayzen-kdab reviewed Feb 3, 2025

View reviewed changes

crates/cxx-qt-gen/src/generator/rust/qobject.rs Outdated Show resolved Hide resolved

ahayzen-kdab reviewed Feb 3, 2025

View reviewed changes

crates/cxx-qt/src/lib.rs Outdated Show resolved Hide resolved

ahayzen-kdab reviewed Feb 3, 2025

View reviewed changes

crates/cxx-qt/src/qobject.rs Show resolved Hide resolved

BenFordTytherington force-pushed the add-up-down-casting branch 2 times, most recently from 6b8d457 to 2786e90 Compare February 7, 2025 10:25

ahayzen-kdab reviewed Feb 7, 2025

View reviewed changes

crates/cxx-qt/src/lib.rs Show resolved Hide resolved

BenFordTytherington force-pushed the add-up-down-casting branch 2 times, most recently from 6578b6b to c60cdfe Compare February 7, 2025 17:24

ahayzen-kdab reviewed Feb 7, 2025

View reviewed changes

crates/cxx-qt-lib/src/core/qstringlist.cpp Show resolved Hide resolved

BenFordTytherington force-pushed the add-up-down-casting branch 4 times, most recently from ba5808c to a08b918 Compare February 14, 2025 12:38

ahayzen-kdab reviewed Feb 14, 2025

View reviewed changes

crates/cxx-qt-lib/src/core/qstringlist.rs Outdated Show resolved Hide resolved

ahayzen-kdab reviewed Feb 14, 2025

View reviewed changes

crates/cxx-qt-lib/src/core/qstringlist.rs Show resolved Hide resolved

ahayzen-kdab reviewed Feb 14, 2025

View reviewed changes

crates/cxx-qt-lib/src/gui/qguiapplication.rs Show resolved Hide resolved

BenFordTytherington force-pushed the add-up-down-casting branch 4 times, most recently from 13da0be to 9ea2336 Compare February 14, 2025 16:04

ahayzen-kdab reviewed Feb 21, 2025

View reviewed changes

BenFordTytherington force-pushed the add-up-down-casting branch 3 times, most recently from 8979b03 to 55eb426 Compare February 21, 2025 16:12

ahayzen-kdab reviewed Feb 21, 2025

View reviewed changes

crates/cxx-qt/src/lib.rs Outdated Show resolved Hide resolved

BenFordTytherington force-pushed the add-up-down-casting branch from 55eb426 to 691c7a0 Compare February 21, 2025 16:19

ahayzen-kdab previously approved these changes Feb 21, 2025

View reviewed changes

BenFordTytherington dismissed ahayzen-kdab’s stale review via 771f91d February 21, 2025 17:03

BenFordTytherington force-pushed the add-up-down-casting branch 2 times, most recently from 5afc056 to f860cea Compare February 21, 2025 17:06

ahayzen-kdab reviewed Feb 24, 2025

View reviewed changes

book/src/bridge/traits.md Outdated Show resolved Hide resolved

ahayzen-kdab reviewed Feb 24, 2025

View reviewed changes

book/src/bridge/traits.md Outdated Show resolved Hide resolved

ahayzen-kdab reviewed Feb 24, 2025

View reviewed changes

book/src/concepts/casting.md Show resolved Hide resolved

LeonMatthesKDAB reviewed Feb 24, 2025

View reviewed changes

book/src/concepts/casting.md Outdated Show resolved Hide resolved

book/src/concepts/casting.md Outdated Show resolved Hide resolved

BenFordTytherington added 5 commits February 28, 2025 10:27

Automatically generate upcasting implementations

0a7e924

- Any bridges with qobjects that have no custom base class will get an upcasting implemention - Adds a new include with the necessary template function for calling static_cast

Add downcasting

fb007b4

Implement basic casting for some lib types

5eb9529

Add casting for QQmlEngine and reexport qobject

32dfaae

Update CHANGELOG

845c6f6

BenFordTytherington force-pushed the add-up-down-casting branch 2 times, most recently from 71ce3ca to 0d46b6e Compare February 28, 2025 10:42

Update book and docs

db8d215

BenFordTytherington force-pushed the add-up-down-casting branch from 0d46b6e to db8d215 Compare February 28, 2025 11:18

BenFordTytherington requested a review from ahayzen-kdab February 28, 2025 11:23

ahayzen-kdab approved these changes Feb 28, 2025

View reviewed changes

ahayzen-kdab merged commit ed8552b into KDAB:main Feb 28, 2025
16 checks passed

BenFordTytherington deleted the add-up-down-casting branch February 28, 2025 11:38

jnbooth mentioned this pull request Mar 1, 2025

Improve manual implementations of up- and downcasting #1204

Merged

BenFordTytherington mentioned this pull request Apr 7, 2025

Traits for CxxQtType/QtObject #562

Closed

Conversation

BenFordTytherington commented Jan 16, 2025

Uh oh!

codecov bot commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ahayzen-kdab left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ahayzen-kdab left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ahayzen-kdab left a comment

Choose a reason for hiding this comment

Uh oh!

ahayzen-kdab commented Feb 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Jan 16, 2025 •

edited

Loading