cxx-qt-gen: allow for safe / unsafe extern "RustQt"#1199
Merged
ahayzen-kdab merged 5 commits intoKDAB:mainfrom Feb 27, 2025
Merged
cxx-qt-gen: allow for safe / unsafe extern "RustQt"#1199ahayzen-kdab merged 5 commits intoKDAB:mainfrom
ahayzen-kdab merged 5 commits intoKDAB:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1199 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 73 73
Lines 12446 12458 +12
=========================================
+ Hits 12446 12458 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We effectively ignore if the unsafe is specified and always consider it to be safe.
ahayzen-kdab
force-pushed
the
extern-rustqt-safe
branch
from
e6d275f to
03c96e3
Compare
LeonMatthesKDAB
approved these changes
Feb 27, 2025
LeonMatthesKDAB
suggested changes
Feb 27, 2025
LeonMatthesKDAB
left a comment
LeonMatthesKDAB
left a comment
There was a problem hiding this comment.
I found some issues after all
As if the individual function is unsafe the block can also be unsafe without any change in behaviour.
ahayzen-kdab
force-pushed
the
extern-rustqt-safe
branch
3 times, most recently
from
3290a98 to
69abab5
Compare
C++Qt block and fn following their original unsafe. RustQt blocks - invokables forward the block or fn unsafe to the fn - signals follow the fn unsafe to the fn - inherit (and signals) require either block or fn Anything with pointers in the arguments requires unsafe on the fn as required by CXX.
ahayzen-kdab
force-pushed
the
extern-rustqt-safe
branch
from
69abab5 to
9acb532
Compare
LeonMatthesKDAB
approved these changes
Feb 27, 2025
LeonMatthesKDAB
left a comment
LeonMatthesKDAB
left a comment
There was a problem hiding this comment.
This seems to behave correctly now.
LeonMatthesKDAB
added
the
⏮️ backport-candidate
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.