Conversation
| not(cxxqt_qt_version_at_least_6_10), | ||
| not(cxxqt_qt_version_at_least_7) | ||
| ))] | ||
| fn mirror(self: &mut QImage, horizontal: bool, vertical: bool); |
There was a problem hiding this comment.
either need to remove mirror now or fix qt_minimal so it exists until Qt 6.13
There was a problem hiding this comment.
What currently needs this, would it be safe to put it behind a feature to use it, so that people can still access it, but we can eventually deprecate the feature?
There was a problem hiding this comment.
So the current test builds of Qt minimal for some reason do not evaluate the C++ macros around deprecated since correctly. So when you try to build with Qt minimal 6.10.0 the method doesn't exist, this is a temporary hack to make it work however a proper solution is either
- Fix Qt minimal to correctly expand it's macros
- Totally remove this method from cxx-qt-lib
- Have some temporary? magical feature to disable/enable it 🤷
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1425 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 75
Lines 13457 13457
=========================================
Hits 13457 13457 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ahayzen-kdab
force-pushed
the
examples-add-qt-minimal-ci
branch
8 times, most recently
from
0b4d30c to
b0486fa
Compare
ahayzen-kdab
force-pushed
the
examples-add-qt-minimal-ci
branch
from
b0486fa to
a57e49e
Compare
2 participants
Requires #1424