Skip to content

feat: add QQmlImageProviderBase#1430

Open
dphaldes wants to merge 5 commits intoKDAB:mainfrom
dphaldes:feat/QQmlImageProvider
Open

feat: add QQmlImageProviderBase#1430
dphaldes wants to merge 5 commits intoKDAB:mainfrom
dphaldes:feat/QQmlImageProvider

Conversation

@dphaldes
Copy link
Contributor

@dphaldes dphaldes commented Mar 10, 2026

supercedes #1142

Co-authored-by: Joshua Goins <joshua.goins@kdab.com>
@dphaldes

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (71eee5f) to head (e091394).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1430   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           75        75           
  Lines        13457     13457           
=========================================
  Hits         13457     13457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dphaldes

This comment was marked as outdated.

@dphaldes dphaldes marked this pull request as ready for review March 20, 2026 01:58
@dphaldes
Copy link
Contributor Author

I have "working" implementation here https://github.com/dphaldes/compose/blob/master/src/bridge.rs.
image

Not particularly fond of the solution since it uses an unchecked cast since I wasn't able to figure out how to cast Pin<&mut QQmlImageProviderBase> into *mut QQmlImageProviderBase. The application also segfaults when closing probably because it is trying to release the ImageProvider.

Any ideas appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant