Skip to content

Bump pkg-config-rs dependency to 0.3.26 #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Bump pkg-config-rs dependency to 0.3.26 #335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/qt-build-utils/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ repository = "https://github.com/KDAB/cxx-qt/"

[dependencies]
versions = "4.1.0"
pkg-config = { git = "https://github.com/Be-ing/pkg-config-rs.git", branch = "library_pub" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this won't work as it still requires vendoring of some private methods, but now that upstream has stabilised what we are going to use we can implement this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, alright, I thought the changes linked in the pkg-config-rs PR were enough for our purposes 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will work on decoupling the required code from pkg-config's structs this week.

Copy link
Contributor

@Be-ing Be-ing Oct 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context: I initially tried to use pkg-config, but Qt6 doesn't ship .pc files for static builds yet. Also, using pkg-config would require somehow getting the pkg-config executable on Windows. Instead, we're parsing the .prl files which are used by qmake.

pkg-config = "0.3.26"
regex = "1.6.0"
lazy_static = "1.0"
thiserror = "1.0"