Bugfix/Issue 1930: Fixed type from char to int #1932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Ah, the famous "char is signed or unsigned" problem :) I thought that has been settled as clang and gcc treat it the signed on both Linux and Windows, but ARM appears to be an exception. Usually I try to avoid that, but here it escaped me. "signed char" would have solved the issue too, but now we're prepared for line widths >=128. Lovely :) Thanks for the patch. Best regards, Matthias |
Collaborator
|
P.S. I don't know why, but the Azure builds are randomly failing while trying to download the Windows build bits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1930