Skip to content

Fixing bug #1953 (inconsistent behavior of callback) maybe #1958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
klayoutmatthias merged 1 commit into from
Jan 4, 2025
Merged

Fixing bug #1953 (inconsistent behavior of callback) maybe #1958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/edt/edt/edtPCellParametersPage.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ PCellParametersPage::setup (lay::LayoutViewBase *view, int cv_index, const db::P
m_initial_states = m_states;
mp_error_frame->hide ();

update_widgets_from_states (m_states);
update_widgets_from_states (m_states, lazy_evaluation ());

mp_parameters_area->setWidget (mp_main_frame);
mp_main_frame->show ();
Expand Down Expand Up @@ -713,7 +713,7 @@ PCellParametersPage::do_parameter_changed ()
db::ParameterStates states = m_states;
get_parameters (states, &ok); // includes coerce
if (ok) {
update_widgets_from_states (states);
update_widgets_from_states (states, lazy_evaluation ());
if (! lazy_evaluation ()) {
emit edited ();
}
Expand Down Expand Up @@ -959,11 +959,11 @@ PCellParametersPage::set_parameters (const std::vector<tl::Variant> &parameters)
m_initial_states = m_states;
mp_error_frame->hide ();

set_parameters_internal (m_states, false);
update_widgets_from_states (m_states, false);
}

void
PCellParametersPage::update_widgets_from_states (const db::ParameterStates &states)
PCellParametersPage::update_widgets_from_states (const db::ParameterStates &states, bool tentatively)
{
if (! mp_pcell_decl) {
return;
Expand Down Expand Up @@ -1031,7 +1031,7 @@ PCellParametersPage::update_widgets_from_states (const db::ParameterStates &stat

}

set_parameters_internal (states, lazy_evaluation ());
set_parameters_internal (states, tentatively);

// QGridLayouts are bad in handling nested QFrame (or QGroupBox) with their own layouts,
// so we help a little here:
Expand Down
2 changes: 1 addition & 1 deletion src/edt/edt/edtPCellParametersPage.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ private slots:
bool lazy_evaluation ();
void set_parameters_internal (const db::ParameterStates &states, bool tentatively);
bool update_current_parameters ();
void update_widgets_from_states (const db::ParameterStates &states);
void update_widgets_from_states (const db::ParameterStates &states, bool tentatively);
void get_parameters_internal (db::ParameterStates &states, bool &edit_error);
std::vector<tl::Variant> parameter_from_states (const db::ParameterStates &states) const;
void states_from_parameters (db::ParameterStates &states, const std::vector<tl::Variant> &parameters);
Expand Down
Loading