Skip to content

Conversation

@tvt173
Copy link

@tvt173 tvt173 commented May 21, 2025

hi @klayoutmatthias this PR aims to add support for ARM linux, for the klayout python package.

fixes #2054

@tvt173 tvt173 mentioned this pull request May 21, 2025
@klayoutmatthias
Copy link
Collaborator

Thanks!

But why is the github pipeline not running at all?

Did I disable PR checking on forks somehow? I am not aware of that.

Matthias

@klayoutmatthias
Copy link
Collaborator

klayoutmatthias commented May 22, 2025

In this PR, github actions are running: #2052

So what is different here? I can't find a log, so maybe the change somehow breaks the actions?

Some whitespaces have sneaked into the patch. Maybe those are responsible for the fail?

Matthias

@tvt173
Copy link
Author

tvt173 commented May 22, 2025

not sure, but i can take a look. i wasn't sure if maybe it was a permissions issue for external contributors running actions, but the other PR should be the same case. i can try reverting the changes to make sure the actions run nominally in the PR

@tvt173
Copy link
Author

tvt173 commented May 23, 2025

hi @klayoutmatthias , i think this PR is ready now. i don't have permissions to run the actions on the PR, so i temporarily created a separate workflow to run on my fork to test. it seems to work, and if you approve the workflow to run on this PR, i belive it should work here too
https://github.com/tvt173/klayout/actions/runs/15203318020

@klayoutmatthias
Copy link
Collaborator

Thanks a lot! Apparently I have to approve the PR once to trigger the github builds. Right now they are running ... let's see what we will get.

Best regards,

Matthias

@klayoutmatthias
Copy link
Collaborator

klayoutmatthias commented May 25, 2025

I think it worked :)

Artifacts can be downloaded here: https://github.com/KLayout/klayout/actions/runs/15205144783/artifacts/3191120067

On a Raspberry PI running Ubuntu 24.04 I can install and use the package:

image

I guess I can merge this PR. Or would you like to try yourself first?

Thanks for your efforts to set this up!

Matthias

@klayoutmatthias klayoutmatthias merged commit d10683e into KLayout:master May 27, 2025
26 checks passed
@joamatab
Copy link
Contributor

Thank you @klayoutmatthias !

Could we make a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

arm wheels for linux

3 participants