Implemented a fix for issue #2191 (LIBNAME not saved) #2192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix consists of moving that options into the case-specific options like DBU, instead of having it in the format-specific, default writer options. So they can be specified on a per-case basis and taken from the current layout by default. Specifically: * SaveLayoutOptions#gds2_libname is deprecated and replaced by SaveLayoutOptions#libname * -ol (buddy tools) is no longer format specific * The GDS writer takes SaveLayoutOptions#libname, and if empty, substitutes by the current libname. As last resort, "LIB" is used, because LIBNAME cannot be an empty string. * The libname got removed from the global writer options UI * In the "Save As" options dialog, it now is part of the global options and initialized with the current layout's libname.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix consists of moving that options into the case-specific options like DBU, instead of having it in the format-specific, default writer options. So they can be specified on a per-case basis and taken from the current layout by default.
Specifically: