Skip to content

Fix MaxListenersExceededWarning in socket event handlers #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix MaxListenersExceededWarning in socket event handlers #34

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
598a3e5
fix: resolve MaxListenersExceededWarning in socket event handlers
sbs44 Nov 13, 2025
7093063
refactor: use socket.once() to prevent listener accumulation
sbs44 Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ function request(options, data = "") {
});

req.on("socket", (socket) => {
socket.setMaxListeners(100);
socket.on("lookup", () => {
dnsLookup = performance.now();
});
Expand Down
3 changes: 3 additions & 0 deletions test/cli.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ describe('Speed Test CLI', () => {
on: jest.fn((event, callback) => {
if (event === 'socket') {
const mockSocket = {
setMaxListeners: jest.fn(),
on: jest.fn((socketEvent, socketCallback) => {
if (socketEvent === 'lookup') setTimeout(() => socketCallback(), 1);
if (socketEvent === 'connect') setTimeout(() => socketCallback(), 2);
Expand Down Expand Up @@ -206,6 +207,7 @@ describe('Speed Test CLI', () => {
on: jest.fn((event, callback) => {
if (event === 'socket') {
const mockSocket = {
setMaxListeners: jest.fn(),
on: jest.fn((socketEvent, socketCallback) => {
if (socketEvent === 'lookup') setTimeout(() => socketCallback(), 1);
if (socketEvent === 'connect') setTimeout(() => socketCallback(), 2);
Expand Down Expand Up @@ -255,6 +257,7 @@ describe('Speed Test CLI', () => {
on: jest.fn((event, callback) => {
if (event === 'socket') {
const mockSocket = {
setMaxListeners: jest.fn(),
on: jest.fn((socketEvent, socketCallback) => {
if (socketEvent === 'lookup') setTimeout(() => socketCallback(), 1);
if (socketEvent === 'connect') setTimeout(() => socketCallback(), 2);
Expand Down