Skip to content

Conversation

@davrikn
Copy link
Contributor

@davrikn davrikn commented Mar 16, 2021

Bugfix, issue #18

@andstor
Copy link
Member

andstor commented Apr 11, 2021

@davrikn I would like the Comment and close issue to only appear if there is actually some text in the input field. Otherwise, keep the button label as Close issue. This should be handled with some simple JavaScript.

Create a class named IssueView in a new JS file called issue_view, invoke it from the question_issue_page.mustache by adding the code below. Implement the button labeling feature in the issue_view file's IssueView class.

{{#js}}
require(['jquery', 'local_qtracker/issue_view'], function($, IssueView) {
    new IssueView();
    ...
});
{{/js}}

@andstor andstor mentioned this pull request Apr 11, 2021
@hgeorgsch
Copy link
Contributor

Merging in develop, this no longer seems relevant. The changes affect an IssueView which no longer is called from any other files.
We should probably close it, but I leave it open in case we need to look for ideas in case of bugs during testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants