fix: prevent metadata corruption for weba and flac files#2868
Open
thumb2086 wants to merge 1 commit intoKRTirtho:devfrom
Open
fix: prevent metadata corruption for weba and flac files#2868thumb2086 wants to merge 1 commit intoKRTirtho:devfrom
thumb2086 wants to merge 1 commit intoKRTirtho:devfrom
Conversation
thumb2086
commented
Nov 25, 2025
thumb2086
commented
- Skip metadata writing for flac files to prevent file corruption
- FLAC files have strict header requirements where writing metadata after download can corrupt the sync code and make files unplayable
- Update download_manager_provider.dart to check for both weba and flac extensions
- Update server/routes/playback.dart to check for both weba and flac extensions
- Add explanatory comments documenting why metadata writing is skipped for these formats
- Refactor extension checking to use variable assignment for clarity
- Skip metadata writing for flac files to prevent file corruption - FLAC files have strict header requirements where writing metadata after download can corrupt the sync code and make files unplayable - Update download_manager_provider.dart to check for both weba and flac extensions - Update server/routes/playback.dart to check for both weba and flac extensions - Add explanatory comments documenting why metadata writing is skipped for these formats - Refactor extension checking to use variable assignment for clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.