Skip to content

Fix #3149: Allow kOS users to read the non-gui KSPField properties #3150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JonnyOThan merged 10 commits into from
Oct 25, 2025
Merged

Fix #3149: Allow kOS users to read the non-gui KSPField properties #3150

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cd494bf
Just removed the checks
Oct 17, 2025
8cbc2bd
Refactor it by creating a 3 new suffixes.
Oct 20, 2025
b40b60d
Revert changes to the solution properties file
Oct 20, 2025
5d7eb18
No need to make HasHiddenField virtual
Oct 20, 2025
7880fce
Added the GEtAllHiddenFieldNames suffix. Refactored some inherited me…
Oct 21, 2025
a8e418d
Refactor FieldISVisible method to prevent nulls from sneaking into th…
Oct 21, 2025
8f8d0d4
Forgot to update this.
Oct 21, 2025
40bab46
Update the docs
Oct 21, 2025
ce0b216
Use GUI instead of UI everywhere
Oct 21, 2025
1ea7ebe
Fix typos.
Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions kOS.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,7 @@
<Company></Company>
<Version>1.5.1.0</Version>
</PropertyGroup>
<PropertyGroup>
<KSPRoot>E:\Games\Kerbal Space Program RSS</KSPRoot>
</PropertyGroup>
Comment thread
AntonKuzin marked this conversation as resolved.
Outdated
</Project>
4 changes: 1 addition & 3 deletions src/kOS/Suffixed/PartModuleField/PartModuleFields.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ protected virtual ListValue AllFieldNames()
/// <returns>true if it is on the PartModule, false if it is not</returns>
public virtual BooleanValue HasField(StringValue fieldName)
{
return FieldIsVisible(GetField(fieldName));
return GetField(fieldName) != null;
}

/// <summary>
Expand Down Expand Up @@ -443,8 +443,6 @@ protected Structure GetKSPFieldValue(StringValue suffixName)
BaseField field = GetField(suffixName);
if (field == null)
throw new KOSLookupFailException("FIELD", suffixName, this);
if (!FieldIsVisible(field))
throw new KOSLookupFailException("FIELD", suffixName, this, true);
Structure obj = FromPrimitiveWithAssert(field.GetValue(partModule));
return obj;
}
Expand Down