Add assertrange <min> <max> instruction
#3159
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3158
This PR implements the
assertrange <min> <max>opcode as proposed in the linked issue.It validates that the value on top of the stack is within the specified range without consuming it.
It throws an exception if it is called with an empty stack, the value isn't a Scalar, or the value lies outside of the specified range (inclusive on both sides).
The
minandmaxfields can be any two doubles.A coercion using
Convert.ToDouble(..)is made to allow for integer inputs.if
PseudoNullis used as an argument, the range will be open.It does not validate that
minis smaller thanmax.The kerboscript compiler hasn't been altered and this feature is only accessible through manual / external compilation.
This addition is backward compatible and changes no underlying behavior.
This PR does not yet implement the optional open range behavior.minmaxPseudoNullPseudoNullPseudoNullPseudoNull